From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJhwg-0006WR-U9 for qemu-devel@nongnu.org; Fri, 28 Oct 2011 04:37:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJhwf-00086m-En for qemu-devel@nongnu.org; Fri, 28 Oct 2011 04:37:46 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:44064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJhwf-00086i-AR for qemu-devel@nongnu.org; Fri, 28 Oct 2011 04:37:45 -0400 Received: by eyh6 with SMTP id 6so3830776eyh.4 for ; Fri, 28 Oct 2011 01:37:43 -0700 (PDT) Date: Fri, 28 Oct 2011 08:40:27 +0100 From: Stefan Hajnoczi Message-ID: <20111028074027.GA18132@stefanha-thinkpad.localdomain> References: <20111014150510.610f6deb@doriath> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111014150510.610f6deb@doriath> Subject: Re: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel , mst@redhat.com On Fri, Oct 14, 2011 at 03:05:10PM -0300, Luiz Capitulino wrote: > I'm getting: > > could not configure /dev/net/tun (tap%d): Operation not permitted > > When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. > So we better only use it when ifname contains a string. > > Signed-off-by: Luiz Capitulino > --- > > PS: Trivial tree candidate. > > net/tap-linux.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next Stefan