qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] [v8 Patch 1/6]Qemu: Enhance "info block" to display host cache setting
Date: Sun, 30 Oct 2011 16:03:54 +0530	[thread overview]
Message-ID: <20111030103354.31685.6508.sendpatchset@skannery.in.ibm.com> (raw)
In-Reply-To: <20111030103327.31685.17045.sendpatchset@skannery.in.ibm.com>

Enhance "info block" to display hostcache setting for each
block device.

Example:
(qemu) info block
ide0-hd0: removable=0 file=../sles11-32.raw ro=0 drv=raw encrypted=0

Enhanced to display "hostcache" setting:
(qemu) info block
ide0-hd0: removable=0 hostcache=1 file=../sles11-32.raw ro=0 drv=raw encrypted=0

Signed-off-by: Supriya Kannery <supriyak@linux.vnet.ibm.com>

---
 block.c         |   20 ++++++++++++++++----
 qmp-commands.hx |    2 ++
 2 files changed, 18 insertions(+), 4 deletions(-)

Index: qemu/qmp-commands.hx
===================================================================
--- qemu.orig/qmp-commands.hx
+++ qemu/qmp-commands.hx
@@ -1142,6 +1142,7 @@ Each json-object contain the following:
 - "locked": true if the device is locked, false otherwise (json-bool)
 - "tray-open": only present if removable, true if the device has a tray,
                and it is open (json-bool)
+- "hostcache": true if host pagecache enabled, false otherwise (json-bool)
 - "inserted": only present if the device is inserted, it is a json-object
    containing the following:
          - "file": device file name (json-string)
@@ -1168,6 +1169,7 @@ Example:
             "io-status": "ok",
             "device":"ide0-hd0",
             "locked":false,
+            "hostcache":false,
             "removable":false,
             "inserted":{
                "ro":false,
Index: qemu/block.c
===================================================================
--- qemu.orig/block.c
+++ qemu/block.c
@@ -1841,6 +1841,11 @@ static void bdrv_print_dict(QObject *obj
                        qdict_get_bool(bs_dict, "tray-open"));
     }
 
+    if (qdict_haskey(bs_dict, "hostcache")) {
+        monitor_printf(mon, " hostcache=%d",
+                       qdict_get_bool(bs_dict, "hostcache"));
+    }
+
     if (qdict_haskey(bs_dict, "io-status")) {
         monitor_printf(mon, " io-status=%s", qdict_get_str(bs_dict, "io-status"));
     }
@@ -1888,10 +1893,12 @@ void bdrv_info(Monitor *mon, QObject **r
         QDict *bs_dict;
 
         bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': 'unknown', "
-                                    "'removable': %i, 'locked': %i }",
+                                    "'removable': %i, 'locked': %i, "
+                                    "'hostcache': %i }",
                                     bs->device_name,
                                     bdrv_dev_has_removable_media(bs),
-                                    bdrv_dev_is_medium_locked(bs));
+                                    bdrv_dev_is_medium_locked(bs),
+                                    !(bs->open_flags & BDRV_O_NOCACHE));
         bs_dict = qobject_to_qdict(bs_obj);
 
         if (bdrv_dev_has_removable_media(bs)) {

  reply	other threads:[~2011-10-30 10:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-30 10:33 [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Supriya Kannery
2011-10-30 10:33 ` Supriya Kannery [this message]
2011-11-03 13:55   ` [Qemu-devel] [v8 Patch 1/6]Qemu: Enhance "info block" to display host cache setting Luiz Capitulino
2011-11-04 10:55     ` Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 2/6]Qemu: Error classes for file reopen and data sync failure Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd "block_set_hostcache" for dynamic cache change Supriya Kannery
2011-11-04 10:00   ` Kevin Wolf
2011-11-04 11:03     ` Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 4/6]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
2011-10-30 10:35 ` [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely Supriya Kannery
2011-11-04 10:05   ` Kevin Wolf
2011-11-04 11:10     ` Supriya Kannery
2011-10-30 10:35 ` [Qemu-devel] [v8 Patch 6/6]Qemu: raw posix implementation of reopen functions Supriya Kannery
2011-11-04 10:19   ` Kevin Wolf
2011-11-04  2:29 ` [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Zhi Yong Wu
2011-11-07  8:38   ` Supriya Kannery
2011-11-07  8:49     ` Zhi Yong Wu
2011-11-07  9:35       ` Supriya Kannery
2011-11-07 10:24         ` Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111030103354.31685.6508.sendpatchset@skannery.in.ibm.com \
    --to=supriyak@linux.vnet.ibm.com \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).