From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] sysbus: Supply missing va_end()
Date: Mon, 31 Oct 2011 11:52:26 +0000 [thread overview]
Message-ID: <20111031115226.GA10693@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1319791946-15602-2-git-send-email-armbru@redhat.com>
On Fri, Oct 28, 2011 at 10:52:25AM +0200, Markus Armbruster wrote:
> C99 7.15.1: Each invocation of the va_start and va_copy macros shall
> be matched by a corresponding invocation of the va_end macro in the
> same function.
>
> Spotted by Coverity. Harmless on the (common) systems where va_end()
> does nothing.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/sysbus.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan
next prev parent reply other threads:[~2011-10-31 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 8:52 [Qemu-devel] [PATCH 0/2] Trivial portability fix: missing va_end() Markus Armbruster
2011-10-28 8:52 ` [Qemu-devel] [PATCH 1/2] sysbus: Supply " Markus Armbruster
2011-10-31 11:52 ` Stefan Hajnoczi [this message]
2011-10-28 8:52 ` [Qemu-devel] [PATCH 2/2] hw/9pfs: " Markus Armbruster
2011-10-31 11:51 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031115226.GA10693@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).