From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLAHd-0001tf-TL for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLAHT-0001z0-Ic for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:25 -0400 Received: from mtagate1.uk.ibm.com ([194.196.100.161]:39714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLAHS-0001y8-Tf for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:15 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pA195AR0032266 for ; Tue, 1 Nov 2011 09:05:10 GMT Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA1959xC2531492 for ; Tue, 1 Nov 2011 09:05:09 GMT Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA1959qG028931 for ; Tue, 1 Nov 2011 03:05:09 -0600 Date: Tue, 1 Nov 2011 07:50:51 +0000 From: Stefan Hajnoczi Message-ID: <20111101075051.GA27637@stefanha-thinkpad.localdomain> References: <1320061773-10634-1-git-send-email-stefanha@linux.vnet.ibm.com> <87mxchgi0a.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mxchgi0a.fsf@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: qemu-devel@nongnu.org, Markus Armbruster On Mon, Oct 31, 2011 at 11:28:45PM +0530, Aneesh Kumar K.V wrote: > On Mon, 31 Oct 2011 11:49:33 +0000, Stefan Hajnoczi wrote: > > Markus Armbruster sent fixes for va_list vararg > > issues in v9fs_string_alloc_printf(). It turns out the function > > duplicates g_vasprintf() and can therefore be eliminated entirely. > > > > Signed-off-by: Stefan Hajnoczi > > Reviewed-by: Aneesh Kumar K.V Do you want to take this into your 9pfs tree? Stefan