From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLAHj-00021J-14 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLAHT-0001zD-PK for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:30 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:36599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLAHT-0001y9-4L for qemu-devel@nongnu.org; Tue, 01 Nov 2011 05:05:15 -0400 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pA195A5W001101 for ; Tue, 1 Nov 2011 09:05:10 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA195AH92461800 for ; Tue, 1 Nov 2011 09:05:10 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA1959Lc030194 for ; Tue, 1 Nov 2011 03:05:10 -0600 Date: Tue, 1 Nov 2011 07:54:21 +0000 From: Stefan Hajnoczi Message-ID: <20111101075421.GB27637@stefanha-thinkpad.localdomain> References: <1320128513-16208-1-git-send-email-wdongxu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1320128513-16208-1-git-send-email-wdongxu@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2] use g_free, instead of free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Dong Xu Wang , qemu-devel@nongnu.org On Tue, Nov 01, 2011 at 02:21:53PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > Fix mismatching allocation and deallocation: g_free should be used to pair with g_malloc. > Also fix coding style. > > Signed-off-by: Dong Xu Wang > --- > block/cloop.c | 119 +++++++++++++++++++++++++++++++-------------------------- > 1 files changed, 65 insertions(+), 54 deletions(-) Kevin: Please consider this for the block tree. Stefan