From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLOiw-0001c9-Ha for qemu-devel@nongnu.org; Tue, 01 Nov 2011 20:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLOiu-0005Nc-4p for qemu-devel@nongnu.org; Tue, 01 Nov 2011 20:30:34 -0400 Date: Wed, 2 Nov 2011 10:59:18 +1100 From: David Gibson Message-ID: <20111101235918.GC5379@truffala.fritz.box> References: <1320006193-15219-1-git-send-email-agraf@suse.de> <1320006193-15219-19-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 18/22] PPC: Fail configure when libfdt is not available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On Tue, Nov 01, 2011 at 07:28:45PM +0000, Blue Swirl wrote: > On Sun, Oct 30, 2011 at 20:23, Alexander Graf wrote: > > We have several targets in the PPC tree now that basically require libfdt > > to function properly, namely the pseries and the e500 targets. This dependency > > will rather increase than decrease in the future, so I want to make sure > > that people building shiny new 1.0 actually have libfdt installed to get > > rid of a few ifdefs in the code. > > > > Warning: This patch will likely make configure fail for people who don't > > select their own --target-list, but don't have libfdt development packages > > installed. However, we really need this new dependency to move on. > > I'd still prefer the submodule approach to help win32 and OSX users, > assuming that libfdt builds on those platforms. I've never tried compiling libfdt on win32 or OSX. I did help someone out to get it compiling on FreeBSD, so OSX is likely to be fine. In any case the core of the library is pretty much pure C with only a tiny set of library functions used, even. So no changes to the core code should be necessary, but it is possibly win32 may need changes to libfdt_env.h (which provides that small set of functions). Actually, if using a submodule, arguably libfdt_env.h should be replaced anyway with a version which uses existing qemu primitives for things (byteswapping, in particular). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson