* [Qemu-devel] [PATCH] spapr: fix build
@ 2011-11-01 21:51 Anthony Liguori
2011-11-01 22:16 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2011-11-01 21:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Anthony Liguori, Alex Graf, David Gibson
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
hw/spapr_pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index 2a5e637..7162588 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -51,7 +51,7 @@ static PCIDevice *find_dev(sPAPREnvironment *spapr,
continue;
}
- QLIST_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) {
+ QTAILQ_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) {
PCIDevice *dev = (PCIDevice *)qdev;
if (dev->devfn == devfn) {
return dev;
@@ -397,7 +397,7 @@ int spapr_populate_pci_devices(sPAPRPHBState *phb,
/* Populate PCI devices and allocate IRQs */
devices = 0;
- QLIST_FOREACH(qdev, &bus->qbus.children, sibling) {
+ QTAILQ_FOREACH(qdev, &bus->qbus.children, sibling) {
PCIDevice *dev = DO_UPCAST(PCIDevice, qdev, qdev);
int irq_index = pci_spapr_map_irq(dev, 0);
uint32_t *irqmap = interrupt_map[devices];
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] spapr: fix build
2011-11-01 21:51 [Qemu-devel] [PATCH] spapr: fix build Anthony Liguori
@ 2011-11-01 22:16 ` Alexander Graf
2011-11-02 0:13 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2011-11-01 22:16 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel@nongnu.org, David Gibson
On 01.11.2011, at 14:51, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
If that's what it takes to make it compile for you, please apply it. i'm currently not anywhere close to a box to test it on myself (and figure out what went wrong).
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
> ---
> hw/spapr_pci.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
> index 2a5e637..7162588 100644
> --- a/hw/spapr_pci.c
> +++ b/hw/spapr_pci.c
> @@ -51,7 +51,7 @@ static PCIDevice *find_dev(sPAPREnvironment *spapr,
> continue;
> }
>
> - QLIST_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) {
> + QTAILQ_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) {
> PCIDevice *dev = (PCIDevice *)qdev;
> if (dev->devfn == devfn) {
> return dev;
> @@ -397,7 +397,7 @@ int spapr_populate_pci_devices(sPAPRPHBState *phb,
>
> /* Populate PCI devices and allocate IRQs */
> devices = 0;
> - QLIST_FOREACH(qdev, &bus->qbus.children, sibling) {
> + QTAILQ_FOREACH(qdev, &bus->qbus.children, sibling) {
> PCIDevice *dev = DO_UPCAST(PCIDevice, qdev, qdev);
> int irq_index = pci_spapr_map_irq(dev, 0);
> uint32_t *irqmap = interrupt_map[devices];
> --
> 1.7.4.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] spapr: fix build
2011-11-01 22:16 ` Alexander Graf
@ 2011-11-02 0:13 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2011-11-02 0:13 UTC (permalink / raw)
To: Alexander Graf; +Cc: Blue Swirl, Anthony Liguori, qemu-devel@nongnu.org
On Tue, Nov 01, 2011 at 03:16:14PM -0700, Alexander Graf wrote:
>
>
>
>
> On 01.11.2011, at 14:51, Anthony Liguori <aliguori@us.ibm.com> wrote:
>
> > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> If that's what it takes to make it compile for you, please apply
> it. i'm currently not anywhere close to a box to test it on myself
> (and figure out what went wrong).
>
> Reviewed-by: Alexander Graf <agraf@suse.de>
I independently created this patch yesterday and it worked, so
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-02 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 21:51 [Qemu-devel] [PATCH] spapr: fix build Anthony Liguori
2011-11-01 22:16 ` Alexander Graf
2011-11-02 0:13 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).