From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLZPp-0004gJ-Ef for qemu-devel@nongnu.org; Wed, 02 Nov 2011 07:55:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLZPo-0006UJ-9C for qemu-devel@nongnu.org; Wed, 02 Nov 2011 07:55:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLZPo-0006Tp-24 for qemu-devel@nongnu.org; Wed, 02 Nov 2011 07:55:32 -0400 Date: Wed, 2 Nov 2011 13:01:31 +0200 From: "Michael S. Tsirkin" Message-ID: <20111102110129.GG5613@redhat.com> References: <1320041218-30487-1-git-send-email-david@gibson.dropbear.id.au> <1320041218-30487-6-git-send-email-david@gibson.dropbear.id.au> <4EAED0A6.4030808@weilnetz.de> <4EB0557C.70408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EB0557C.70408@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , eduard.munteanu@linux360.ro, qemu-devel@nongnu.org, agraf@suse.de, avi@redhat.com, joerg.roedel@amd.com, rth@twiddle.net, David Gibson On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > >Hi, > > > >the patch looks reasonable. I only suggest a formal change: > > > >There are lots of unnecessary type casts in several of your patches. > >I marked them here, but they should be removed anywhere. > > Agreed. However, I'm going to apply this series as I'd like to get > it in for the freeze. But David, please follow up with a patch to > remove the unnecessary type casts. > > Regards, > > Anthony Liguori Further, eepro100 now needs to be fixed to use pci_dma_write/read instead of stXXX/ldXXX, as address passed in apparently can be unaligned. -- MST