From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RNSER-0005v6-DN
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 11:39:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RNSEQ-0002g2-A7
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 11:39:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RNSEP-0002ft-Uc
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 11:39:34 -0500
Date: Mon, 7 Nov 2011 14:39:29 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20111107143929.2335a059@doriath>
In-Reply-To: <4EB808E7.3000507@codemonkey.ws>
References: <1320678675-21379-1-git-send-email-aliguori@us.ibm.com>
	<20111107140801.7f1c6cdd@doriath> <4EB802D3.4080108@codemonkey.ws>
	<20111107143020.74c678ec@doriath> <4EB808E7.3000507@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Mon, 07 Nov 2011 10:35:51 -0600
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 11/07/2011 10:30 AM, Luiz Capitulino wrote:
> > On Mon, 07 Nov 2011 10:09:55 -0600
> > Anthony Liguori<anthony@codemonkey.ws>  wrote:
> >
> >> On 11/07/2011 10:08 AM, Luiz Capitulino wrote:
> >>> On Mon,  7 Nov 2011 09:11:15 -0600
> >>> Anthony Liguori<aliguori@us.ibm.com>   wrote:
> >>>
> >>>> I wrote this quickly to aid in testing.  It's similar to qmp-shell with a few
> >>>> important differences:
> >>>>
> >>>> 1) It is not interactive.  That makes it useful for scripting.
> >>>>
> >>>> 2) qmp-shell:
> >>>>
> >>>> (QEMU) set_password protocol=vnc password=foo
> >>>>
> >>>> 3) qmp:
> >>>>
> >>>> $ qmp set_password --protocol=vnc --password=foo
> >>>>
> >>>> 4) Extensible, git-style interface.  If an invalid command name is passed, it
> >>>>      will try to exec qmp-$1.
> >>>>
> >>>> 5) It attempts to pretty print the JSON responses in a shell friendly format
> >>>>      such that tools can work with the output.
> >>>>
> >>>> Hope others will also find it useful.
> >>>>
> >>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
> >>>
> >>> Acked-by: Luiz Capitulino<lcapitulino@redhat.com>
> >>
> >> BTW, one thing I'd like to try at some point soon is to generate man pages from
> >> qapi-schema.json.  If you notice in the script, it does online help by invoking man.
> >
> > Yes, I did notice it. I didn't comment on it because I imagined you had plans
> > about it.
> >
> > PS: I don't think this needs to go through my tree.
> 
> What do you want to do with qmp.py?  Do you feel comfortable installing it in 
> $PYTHONPATH and treating it as a supported API?

I probably don't. I coded it as demo in the very beginning of QMP, maybe
we should first define what we expect from a QMP Python class then we
can see whether it fits or not... I feel it needs to be revamped.