From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQY2F-00066i-VZ for qemu-devel@nongnu.org; Wed, 16 Nov 2011 00:27:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQY2A-0004V7-U8 for qemu-devel@nongnu.org; Wed, 16 Nov 2011 00:27:47 -0500 Date: Wed, 16 Nov 2011 16:25:05 +1100 From: David Gibson Message-ID: <20111116052505.GC19982@truffala.fritz.box> References: <1321419193-31627-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1321419193-31627-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Fix qdev.id handling in the VIO bus code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de Cc: michael@ellerman.id.au, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, Nov 16, 2011 at 03:53:13PM +1100, David Gibson wrote: > From: Michael Ellerman > > When the user creates a device on the command line with -device, they > can specify the id, using id=foo. Currently the VIO bus code overwrites > this id with it's own value. We should only set qdev.id if it is not > already set by the user. > > The device tree code uses qdev.id for the device tree node name, however > we can't rely on the user specifiying the id using proper device tree > syntax, ie. device@reg. So separate the device tree node name from the > qdev.id, but use the same syntax, so they will match by default. > > Signed-off-by: Michael Ellerman This is again a bugfix which I hope will go into 1.0. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson