* [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean
@ 2011-11-16 21:58 Michael S. Tsirkin
2011-11-17 9:31 ` Paolo Bonzini
2011-11-17 13:21 ` Luiz Capitulino
0 siblings, 2 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2011-11-16 21:58 UTC (permalink / raw)
Cc: Anthony Liguori, Stefan Hajnoczi, Michael S. Tsirkin, qemu-devel,
Michael Roth, Luiz Capitulino
make clean missed the source qmp files generated
by python. Fix that.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 168093c..b335f2a 100644
--- a/Makefile
+++ b/Makefile
@@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
GENERATED_HEADERS += trace-dtrace.h
endif
GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
+GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
ifneq ($(wildcard config-host.mak),)
# Put the all: rule here so that config-host.mak can contain dependencies.
@@ -227,6 +228,7 @@ clean:
rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
rm -f trace-dtrace.h trace-dtrace.h-timestamp
+ rm -f $(GENERATED_SOURCES)
rm -rf $(qapi-dir)
$(MAKE) -C tests clean
for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \
--
1.7.5.53.gc233e
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean
2011-11-16 21:58 [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean Michael S. Tsirkin
@ 2011-11-17 9:31 ` Paolo Bonzini
2011-11-17 13:21 ` Luiz Capitulino
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2011-11-17 9:31 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Michael Roth, Anthony Liguori, Luiz Capitulino, Stefan Hajnoczi,
qemu-devel
On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
> make clean missed the source qmp files generated
> by python. Fix that.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> ---
> Makefile | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 168093c..b335f2a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
> GENERATED_HEADERS += trace-dtrace.h
> endif
> GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
> +GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
>
> ifneq ($(wildcard config-host.mak),)
> # Put the all: rule here so that config-host.mak can contain dependencies.
> @@ -227,6 +228,7 @@ clean:
> rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
> rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
> rm -f trace-dtrace.h trace-dtrace.h-timestamp
> + rm -f $(GENERATED_SOURCES)
> rm -rf $(qapi-dir)
> $(MAKE) -C tests clean
> for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \
Series looks good,
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean
2011-11-16 21:58 [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean Michael S. Tsirkin
2011-11-17 9:31 ` Paolo Bonzini
@ 2011-11-17 13:21 ` Luiz Capitulino
2011-11-17 13:38 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Luiz Capitulino @ 2011-11-17 13:21 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Michael Roth, Anthony Liguori, qemu-devel, Stefan Hajnoczi
On Wed, 16 Nov 2011 23:58:46 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> make clean missed the source qmp files generated
> by python. Fix that.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Michael, this series is for 1.0, right?
> ---
> Makefile | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 168093c..b335f2a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
> GENERATED_HEADERS += trace-dtrace.h
> endif
> GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
> +GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
>
> ifneq ($(wildcard config-host.mak),)
> # Put the all: rule here so that config-host.mak can contain dependencies.
> @@ -227,6 +228,7 @@ clean:
> rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
> rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
> rm -f trace-dtrace.h trace-dtrace.h-timestamp
> + rm -f $(GENERATED_SOURCES)
> rm -rf $(qapi-dir)
> $(MAKE) -C tests clean
> for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean
2011-11-17 13:21 ` Luiz Capitulino
@ 2011-11-17 13:38 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2011-11-17 13:38 UTC (permalink / raw)
To: Luiz Capitulino
Cc: Michael Roth, Anthony Liguori, qemu-devel, Stefan Hajnoczi
On Thu, Nov 17, 2011 at 11:21:01AM -0200, Luiz Capitulino wrote:
> On Wed, 16 Nov 2011 23:58:46 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > make clean missed the source qmp files generated
> > by python. Fix that.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Michael, this series is for 1.0, right?
Yes, I think so.
> > ---
> > Makefile | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 168093c..b335f2a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
> > GENERATED_HEADERS += trace-dtrace.h
> > endif
> > GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
> > +GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
> >
> > ifneq ($(wildcard config-host.mak),)
> > # Put the all: rule here so that config-host.mak can contain dependencies.
> > @@ -227,6 +228,7 @@ clean:
> > rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
> > rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
> > rm -f trace-dtrace.h trace-dtrace.h-timestamp
> > + rm -f $(GENERATED_SOURCES)
> > rm -rf $(qapi-dir)
> > $(MAKE) -C tests clean
> > for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-17 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 21:58 [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files on clean Michael S. Tsirkin
2011-11-17 9:31 ` Paolo Bonzini
2011-11-17 13:21 ` Luiz Capitulino
2011-11-17 13:38 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).