From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RR2CP-0001aR-4Y
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 08:40:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RR299-0008VC-DN
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 08:37:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39362)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RR299-0008V8-5D
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 08:36:55 -0500
Date: Thu, 17 Nov 2011 15:38:21 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20111117133821.GA7580@redhat.com>
References: <20111116215845.GA770@redhat.com> <20111117112101.5310e9bf@doriath>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20111117112101.5310e9bf@doriath>
Subject: Re: [Qemu-devel] [PATCH 1/4] Makefile: remove more generated files
	on clean
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Thu, Nov 17, 2011 at 11:21:01AM -0200, Luiz Capitulino wrote:
> On Wed, 16 Nov 2011 23:58:46 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > make clean missed the source qmp files generated
> > by python. Fix that.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Michael, this series is for 1.0, right?

Yes, I think so.

> > ---
> >  Makefile |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 168093c..b335f2a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -8,6 +8,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
> >  GENERATED_HEADERS += trace-dtrace.h
> >  endif
> >  GENERATED_HEADERS += qmp-commands.h qapi-types.h qapi-visit.h
> > +GENERATED_SOURCES += qmp-marshal.c qapi-types.c qapi-visit.c
> >  
> >  ifneq ($(wildcard config-host.mak),)
> >  # Put the all: rule here so that config-host.mak can contain dependencies.
> > @@ -227,6 +228,7 @@ clean:
> >  	rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
> >  	rm -f trace-dtrace.dtrace trace-dtrace.dtrace-timestamp
> >  	rm -f trace-dtrace.h trace-dtrace.h-timestamp
> > +	rm -f $(GENERATED_SOURCES)
> >  	rm -rf $(qapi-dir)
> >  	$(MAKE) -C tests clean
> >  	for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard; do \