From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RR90j-0004YT-SZ
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 15:56:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RR90i-0004u9-TM
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 15:56:41 -0500
Received: from va3ehsobe002.messaging.microsoft.com ([216.32.180.12]:38042
	helo=VA3EHSOBE002.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RR90i-0004tw-R1
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 15:56:40 -0500
Date: Thu, 17 Nov 2011 14:56:33 -0600
From: Scott Wood <scottwood@freescale.com>
Message-ID: <20111117205633.GA16468@schlenkerla.am.freescale.net>
References: <20111103195452.21259.93021.stgit@bling.home>
	<20111111175118.GA6946@phenom.dumpdata.com>
	<1321049456.2682.220.camel@bling.home>
	<20111116165227.GB2793@phenom.dumpdata.com>
	<1321561337.2633.40.camel@x201.home>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1321561337.2633.40.camel@x201.home>
Subject: Re: [Qemu-devel] [RFC PATCH] vfio: VFIO Driver core framework
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: aafabbri@cisco.com, aik@au1.ibm.com, kvm@vger.kernel.org, pmac@au1.ibm.com, qemu-devel@nongnu.org, joerg.roedel@amd.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, agraf@suse.de, dwg@au1.ibm.com, chrisw@sous-sol.org, B08248@freescale.com, iommu@lists.linux-foundation.org, avi@redhat.com, linux-pci@vger.kernel.org, B07421@freescale.com, benve@cisco.com

On Thu, Nov 17, 2011 at 01:22:17PM -0700, Alex Williamson wrote:
> On Wed, 2011-11-16 at 11:52 -0500, Konrad Rzeszutek Wilk wrote:
> > On Fri, Nov 11, 2011 at 03:10:56PM -0700, Alex Williamson wrote:
> > What would be the return value if somebody tried to unmask an edge one?
> > Should that be documented here? -ENOSPEC?
> 
> I would assume EINVAL or EFAULT since the user is providing an invalid
> argument/bad address.

EINVAL.  EFAULT is normally only used for when the user passes a bad
virtual memory address to the kernel.  This isn't an address at all, it's
an index that points to an object for which this operation does not make
sense.

-Scott