From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RSp2A-0006P5-7O
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:01:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RSp22-0003Dx-Tw
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:01:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RSp22-0003Dl-Hw
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:00:58 -0500
Date: Tue, 22 Nov 2011 10:00:53 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20111122100053.16caef2a@doriath>
In-Reply-To: <4ECA93A9.4090301@suse.de>
References: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com>
	<1321895345-27959-2-git-send-email-lcapitulino@redhat.com>
	<4ECA93A9.4090301@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck
 tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Mon, 21 Nov 2011 19:08:41 +0100
Andreas F=E4rber <afaerber@suse.de> wrote:

> Am 21.11.2011 18:09, schrieb Luiz Capitulino:
> > test-coroutine is listed as a libcheck test in the 'checks' variable. T=
his
> > is not right because 'make check' won't run test-coroutine if libcheck
> > tests are not enabled (either because libcheck isn't detected or because
> > --disable-check-utests is passed).
> >=20
> > Tests using the glib test framework are independent from libcheck and
> > afaik are always present (although having a configure switch to disable
> > them is probably worth it).
> >=20
> > Untagle test-coroutine from the libcheck tests by introducing the
>=20
> Untangle

Fixed, thanks. This series is going to need a respin anyway.

>=20
> > 'test_progs' variable and using it to generate the test list used by
> > 'make check'.
> >=20
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>=20
> Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
>=20
> Andreas
>=20
> > ---
> >  configure |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/configure b/configure
> > index 6c77fbb..ac0fbd9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2685,8 +2685,9 @@ if test "$softmmu" =3D yes ; then
> >      fi
> >      if [ "$check_utests" =3D "yes" ]; then
> >        checks=3D"check-qint check-qstring check-qdict check-qlist"
> > -      checks=3D"check-qfloat check-qjson test-coroutine $checks"
> > +      checks=3D"check-qfloat check-qjson $checks"
> >      fi
> > +    test_progs=3D"$checks test-coroutine"
> >    fi
> >  fi
> > =20
> > @@ -3175,7 +3176,7 @@ if test "$trace_default" =3D "yes"; then
> >  fi
> > =20
> >  echo "TOOLS=3D$tools" >> $config_host_mak
> > -echo "CHECKS=3D$checks" >> $config_host_mak
> > +echo "CHECKS=3D$test_progs" >> $config_host_mak
> >  echo "ROMS=3D$roms" >> $config_host_mak
> >  echo "MAKE=3D$make" >> $config_host_mak
> >  echo "INSTALL=3D$install" >> $config_host_mak
>=20
>=20