From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTdVF-000193-Vt for qemu-devel@nongnu.org; Thu, 24 Nov 2011 12:54:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTdVE-0007cl-VG for qemu-devel@nongnu.org; Thu, 24 Nov 2011 12:54:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTdVE-0007cg-Hd for qemu-devel@nongnu.org; Thu, 24 Nov 2011 12:54:28 -0500 Date: Thu, 24 Nov 2011 19:55:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20111124175436.GA29199@redhat.com> References: <1322137732-30840-1-git-send-email-pbonzini@redhat.com> <20111124164203.GE26770@redhat.com> <4ECE7593.5090902@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ECE7593.5090902@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, agraf@suse.de On Thu, Nov 24, 2011 at 05:49:23PM +0100, Paolo Bonzini wrote: > On 11/24/2011 05:42 PM, Michael S. Tsirkin wrote: > >Most users ignore the return value anyway, > >and virtio_load needs to look at supported features > >mask for the diagnostic anyway. So let's use virtio_set_features > >void. > > Could some backend make it a hard failure? I don't see how, there's no way to report a failure from an io port write. > If I understand > correctly, this would have prevented the BAD_FEATURE bug too. > > Paolo Which bug? what would have prevented it.