qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Mark Wu <wudx05@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/3] block: add support for 4k logical	blocks
Date: Fri, 25 Nov 2011 12:13:10 +0100	[thread overview]
Message-ID: <20111125111310.GA24566@lst.de> (raw)
In-Reply-To: <4ECF517F.5050000@redhat.com>

On Fri, Nov 25, 2011 at 09:27:43AM +0100, Paolo Bonzini wrote:
> No, it adds support for 512b logical block sizes running on a host with 4k 
> logical block size and cache=none.  This is suboptimal as it requires 
> bounce buffers, but it can happen with migration and until libvirt provides 
> a knob for the guest's logical block size.

It's also highly dangerous becausw the fs may assume a sector is written
atomically, but now it isn't.  If at all I would recommend to only support
this case read only.

  reply	other threads:[~2011-11-25 11:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 16:51 [Qemu-devel] [RFC PATCH 0/3] block: add support for 4k logical blocks Paolo Bonzini
2011-11-23 16:51 ` [Qemu-devel] [RFC PATCH 1/3] block: add bdrv_get_alignment, use it Paolo Bonzini
2011-11-23 16:51 ` [Qemu-devel] [RFC PATCH 2/3] raw: implement raw_get_alignment Paolo Bonzini
2011-11-23 16:51 ` [Qemu-devel] [RFC PATCH 3/3] block: do not rely on the buffer alignment passed to the guest Paolo Bonzini
2011-11-25  7:26 ` [Qemu-devel] [RFC PATCH 0/3] block: add support for 4k logical blocks Mark Wu
2011-11-25  8:27   ` Paolo Bonzini
2011-11-25 11:13     ` Christoph Hellwig [this message]
2011-11-28  3:05     ` Mark Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111125111310.GA24566@lst.de \
    --to=hch@lst.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wudx05@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).