From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV6Gt-0000iO-AD for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:49:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RV6Gs-0001VN-9s for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:49:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV6Gs-0001VB-0A for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:49:42 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pASInfcH021549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Nov 2011 13:49:41 -0500 Date: Mon, 28 Nov 2011 20:51:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20111128185118.GD13778@redhat.com> References: <1322138308-31040-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1322138308-31040-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/9] virtio: device configuration cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Thu, Nov 24, 2011 at 01:38:19PM +0100, Paolo Bonzini wrote: > This series cleans up device configuration in virtio: > > 1) all properties (features and not) are moved to a single macro > DEFINE_VIRTIO_XYZ_PROPERTIES. This makes the definitions > uniform across all three virtio backends. > > 2) all configuration is moved to a single struct, which embeds > the NICConf/BlockConf for respectively virtio-nic/virtio-blk. > This lets the DEFINE_VIRTIO_XYZ_PROPERTIES include these > pieces as well. > > 3) virtio-9p had some knowledge of PCI, but there should be > no reason why s390 or mmio backends cannot use it. These bits > are removed and moved back to virtio-pci.[ch]. > > Tested x86_64, compiled arm+s390x. Looks good except the 9p part, commented on that. > Paolo Bonzini (9): > virtio-net: move property declarations to header file > virtio-net: move NICConf into virtio_net_conf > virtio-serial: move property declarations to header file > virtio-9p: remove PCI dependencies from hw/9pfs/ > virtio-9p: move property declarations to header file > virtio-blk: define VirtIOBlkConf > virtio-blk: move property declarations to header file > virtio-blk: move BlockConf into VirtIOBlkConf > virtio: move conf fields into an anonymous union > > hw/9pfs/virtio-9p-device.c | 35 +--------------------- > hw/{9p.h => 9pfs/virtio-9p-device.h} | 9 ++++- > hw/9pfs/virtio-9p.c | 1 - > hw/s390-virtio-bus.c | 18 +++-------- > hw/s390-virtio-bus.h | 11 ++++--- > hw/syborg_virtio.c | 15 +++------ > hw/virtio-blk.c | 28 ++++++++-------- > hw/virtio-blk.h | 12 +++++++ > hw/virtio-net.c | 13 ++++---- > hw/virtio-net.h | 43 +++++++++++++++------------ > hw/virtio-pci.c | 55 +++++++++++++++++++++++---------- > hw/virtio-pci.h | 14 +++++---- > hw/virtio-serial.h | 5 +++ > hw/virtio.h | 9 ++--- > 14 files changed, 135 insertions(+), 133 deletions(-) > rename hw/{9p.h => 9pfs/virtio-9p-device.h} (50%) > > -- > 1.7.7.1