From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: aik@ozlabs.ru, sw@weilnetz.de, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Fix array overrun bug in PCI code
Date: Tue, 29 Nov 2011 18:41:10 +1100 [thread overview]
Message-ID: <20111129074110.GK3508@truffala.fritz.box> (raw)
In-Reply-To: <1322547699-28329-1-git-send-email-david@gibson.dropbear.id.au>
On Tue, Nov 29, 2011 at 05:21:39PM +1100, David Gibson wrote:
> spapr_populate_pci_devices() containd a loop with PCI_NUM_REGIONS (7)
> iterations. However this overruns the 'bars' global array, which only has
> 6 elements. In fact we only want to run this loop for things listed in the
> bars array, so this patch corrects the loop bounds to reflect that.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
As a bugfix for a bad memory access, this is definitely for 1.0
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-11-29 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 6:21 [Qemu-devel] [PATCH] pseries: Fix array overrun bug in PCI code David Gibson
2011-11-29 7:41 ` David Gibson [this message]
2011-12-05 20:24 ` [Qemu-devel] [Qemu-ppc] " andrzej zaborowski
2011-12-05 20:33 ` Alexander Graf
2011-12-19 13:59 ` [Qemu-devel] " Alexander Graf
2011-12-19 14:01 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129074110.GK3508@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).