From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVNSL-0002Xn-P5 for qemu-devel@nongnu.org; Tue, 29 Nov 2011 08:10:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVNSH-0004AV-Ju for qemu-devel@nongnu.org; Tue, 29 Nov 2011 08:10:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVNSH-0004AQ-Bo for qemu-devel@nongnu.org; Tue, 29 Nov 2011 08:10:37 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pATDAabO028659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 29 Nov 2011 08:10:36 -0500 Date: Tue, 29 Nov 2011 15:12:15 +0200 From: "Michael S. Tsirkin" Message-ID: <20111129131215.GD19157@redhat.com> References: <1322138308-31040-1-git-send-email-pbonzini@redhat.com> <1322138308-31040-5-git-send-email-pbonzini@redhat.com> <20111128184617.GC13778@redhat.com> <4ED49A13.9050200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ED49A13.9050200@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/9] virtio-9p: remove PCI dependencies from hw/9pfs/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Tue, Nov 29, 2011 at 09:38:43AM +0100, Paolo Bonzini wrote: > On 11/28/2011 07:46 PM, Michael S. Tsirkin wrote: > >>> +#ifdef CONFIG_LINUX > >>> +static int virtio_9p_init_pci(PCIDevice *pci_dev) > >>> +{ > >>> + VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev); > >>> + VirtIODevice *vdev; > >>> + > >>> + vdev = virtio_9p_init(&pci_dev->qdev,&proxy->fsconf); > >>> + vdev->nvectors = proxy->nvectors; > >>> + virtio_init_pci(proxy, vdev); > >>> + /* make the actual value visible */ > >>> + proxy->nvectors = vdev->nvectors; > >>> + return 0; > >>> +} > >>> +#endif > >>> + > >This ifdef looks wrong to me - is there no way 9p can thinkably > >work on non-linux hosts? If yes, we should have a separate config > >entry for 9p, configure script can make it > >conditional on linux host. > > I think it was true in the beginning, but more recent versions > should only depend on CONFIG_POSIX. I will set up FreeBSD and come > back. > > Paolo It might be easier to add CONFIG_VIRTIO_9P. That won't hurt in any case. -- MST