From: Christoph Hellwig <hch@lst.de>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] block: convert qemu_aio_flush() calls to bdrv_drain_all()
Date: Wed, 30 Nov 2011 13:28:26 +0100 [thread overview]
Message-ID: <20111130122826.GA16826@lst.de> (raw)
In-Reply-To: <1322655824-31778-4-git-send-email-stefanha@linux.vnet.ibm.com>
On Wed, Nov 30, 2011 at 12:23:43PM +0000, Stefan Hajnoczi wrote:
> Many places in QEMU call qemu_aio_flush() to complete all pending
> asynchronous I/O. Most of these places actually want to drain all block
> requests but there is block layer API to do so.
there seems to be a "not" missing in the last half sentence.
>
> This patch introduces the bdrv_drain_all() API to wait for requests
> across all BlockDriverStates to complete. As a bonus we perform checks
> after qemu_aio_wait() to ensure that requests really have finished.
It looks like all but four of the callers actually just want to drain a
single BlockDriverState. And one of those four already has its own loop
over all BlockDriverStates.
next prev parent reply other threads:[~2011-11-30 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 12:23 [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait() issues Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 1/3] qcow2: avoid reentrant bdrv_read() in copy_sectors() Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 2/3] block: wait_for_overlapping_requests() deadlock detection Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 3/3] block: convert qemu_aio_flush() calls to bdrv_drain_all() Stefan Hajnoczi
2011-11-30 12:28 ` Christoph Hellwig [this message]
2011-11-30 12:54 ` Stefan Hajnoczi
2011-12-05 13:57 ` [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait() issues Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130122826.GA16826@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).