From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW2iA-0006i8-T9
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:13:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW2i9-0008Jl-J7
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:13:46 -0500
Received: from mail-ey0-f173.google.com ([209.85.215.173]:53852)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW2i9-0008JU-D6
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:13:45 -0500
Received: by mail-ey0-f173.google.com with SMTP id i10so2138247eaa.4
	for <qemu-devel@nongnu.org>; Thu, 01 Dec 2011 01:13:45 -0800 (PST)
Date: Thu, 1 Dec 2011 08:19:56 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20111201081956.GC29861@stefanha-thinkpad.localdomain>
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>
	<1322687028-29714-2-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1322687028-29714-2-git-send-email-aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 01/18] qom: add new dynamic property
 infrastructure based on Visitors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Nov 30, 2011 at 03:03:31PM -0600, Anthony Liguori wrote:
> +/**
> + * @DevicePropertyEtter - called when trying to get/set a property

An established term for this is an "accessor".  I've never heard "etter"
before and it looks like a typo on first sight ;).

> +/**
> + * @qdev_property_set - writes a property to a device
> + *
> + * @dev - the device
> + *
> + * @v - the visitor that will used to write the property value.  This should be

s/will used/will be used/