From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW4mo-0004Jq-1f
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 06:26:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW4mi-0004oI-Bz
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 06:26:42 -0500
Received: from mail-bw0-f45.google.com ([209.85.214.45]:65176)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RW4mi-0004oE-2m
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 06:26:36 -0500
Received: by bkar19 with SMTP id r19so2660449bka.4
	for <qemu-devel@nongnu.org>; Thu, 01 Dec 2011 03:26:35 -0800 (PST)
Date: Thu, 1 Dec 2011 11:26:31 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20111201112631.GF31730@stefanha-thinkpad.localdomain>
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>
	<1322687028-29714-18-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1322687028-29714-18-git-send-email-aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 17/18] Add test tools
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Nov 30, 2011 at 03:03:47PM -0600, Anthony Liguori wrote:
> diff --git a/QMP/qom-get b/QMP/qom-get
> new file mode 100755
> index 0000000..b086bc5
> --- /dev/null
> +++ b/QMP/qom-get
> @@ -0,0 +1,26 @@
> +#!/usr/bin/python
> +##
> +# Virtio Support

QEMU Object Model property getter utility

> +#
> +# Copyright IBM, Corp. 2011
> +#
> +# Authors:
> +#  Anthony Liguori   <aliguori@us.ibm.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or later.  See
> +# the COPYING file in the top-level directory.
> +##
> +
> +import sys
> +from qmp import QEMUMonitorProtocol
> +
> +srv = QEMUMonitorProtocol('/tmp/server.sock')

I think it would be worth doing it like QMP/qmp-shell.py and using a
command-line argument.  We might also like to support a
QEMU_MONITOR environment variable.

Hardcoding to /tmp/server.sock makes this script less useful.

> diff --git a/QMP/qom-list b/QMP/qom-list
> new file mode 100755
> index 0000000..5dbb07b
> --- /dev/null
> +++ b/QMP/qom-list
> @@ -0,0 +1,30 @@
> +#!/usr/bin/python
> +##
> +# Virtio Support

QEMU Object Model property listing utility

> diff --git a/QMP/qom-set b/QMP/qom-set
> new file mode 100755
> index 0000000..83a4394
> --- /dev/null
> +++ b/QMP/qom-set
> @@ -0,0 +1,21 @@
> +#!/usr/bin/python
> +##
> +# Virtio Support

QEMU Object Model property setter utility