From: Jiri Denemark <jdenemar@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: libvir-list@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] libvirt doesn't work with qemu 1.0
Date: Fri, 2 Dec 2011 16:08:50 +0100 [thread overview]
Message-ID: <20111202150850.GJ2274323@orkuz.home> (raw)
In-Reply-To: <4ED8E5A3.2080909@codemonkey.ws>
On Fri, Dec 02, 2011 at 08:50:11 -0600, Anthony Liguori wrote:
> On 12/02/2011 08:21 AM, Gerd Hoffmann wrote:
> > Hi,
> >
> > $subject says all. The error message is:
> >
> > error: internal error cannot parse /home/kraxel/bin/qemu-default version
> > number in 'QEMU emulator version 1.0, Copyright (c) 2003-2008 Fabrice
> > Bellard'
>
> Parsing help output for the version number is a really bad idea. query-version
> in QMP does the right thing:
>
> (QEMU) query-version
> {u'return': {u'qemu': {u'micro': 0, u'major': 1, u'minor': 0}, u'package': ''}}
Which of course only works with new enough QEMU that is known to support QMP
(which BTW we detect by checking the version number). Anyway, the fix is easy,
we just need to assume micro is 0 if it's missing instead of requiring it to
be present. A fix will come soon.
Jirka
next prev parent reply other threads:[~2011-12-02 15:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 14:21 [Qemu-devel] libvirt doesn't work with qemu 1.0 Gerd Hoffmann
2011-12-02 14:50 ` Anthony Liguori
2011-12-02 15:08 ` Jiri Denemark [this message]
2011-12-02 15:15 ` Anthony Liguori
2011-12-02 19:29 ` [Qemu-devel] [libvirt] " Eric Blake
2011-12-02 20:32 ` Anthony Liguori
2012-01-26 3:55 ` Eric Blake
2012-01-26 9:41 ` Paolo Bonzini
2012-01-26 10:55 ` Markus Armbruster
2012-01-26 12:46 ` Eric Blake
2012-01-26 13:00 ` Paolo Bonzini
2012-01-26 19:23 ` Luiz Capitulino
2011-12-02 18:53 ` Dave Allan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202150850.GJ2274323@orkuz.home \
--to=jdenemar@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).