From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "@amt.cnet@amt.cnet, Eric B Munson <emunson@mgebm.net>,
ryanh@linux.vnet.ibm.com <ryanh@linux.vnet.ibm.com>,
aliguori@us.ibm.com <aliguori@us.ibm.com>,
kvm@vger.kernel.org <kvm@vger.kernel.org>,
qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V3] Guest stop notification
Date: Mon, 5 Dec 2011 11:35:44 -0200 [thread overview]
Message-ID: <20111205133544.GA32052@amt.cnet> (raw)
In-Reply-To: <4EDA0BEF.7010204@web.de>
On Sat, Dec 03, 2011 at 12:45:51PM +0100, Jan Kiszka wrote:
> >> I was referring to the relation between the IOCTL and kvmclock, but
> >> IOCTL vs. kvm_run.
> >>
> >> Jan
> >
> > Ah, OK. Yes, we better characterize it as KVMCLOCK specific (a generic
> > "guest is paused" command is not the scope of this patch).
> >
> > So appending KVMCLOCK_ to the ioctl definitions would make that more
> > explicit.
>
> IMHO, that would move things in the wrong direction. The IOCTL in itself
> has _nothing_ to do with kvmclock. It's just that its x86 backend is
> implemented on top of that infrastructure. For me the IOCTL is pretty
> generic, can be backed by kvmclock, but need not be on all future archs.
>
> Jan
I do not see the need to lift this infrastructure to arch independent
status at the moment, without clear semantics on that arch independent
level.
So I am fine with the current GUEST_PAUSED naming (which can later be
extended with GUEST_RESUMED etc, if necessary, for use by other archs
for example), and implementation in hw/kvmclock.c.
next prev parent reply other threads:[~2011-12-05 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 19:19 [Qemu-devel] [PATCH V3] Guest stop notification Eric B Munson
2011-12-02 20:20 ` Jan Kiszka
2011-12-02 21:27 ` Eric B Munson
2011-12-03 9:06 ` Jan Kiszka
2011-12-03 11:19 ` Marcelo Tosatti
2011-12-03 11:25 ` Jan Kiszka
2011-12-03 11:42 ` Marcelo Tosatti
2011-12-03 11:45 ` Jan Kiszka
2011-12-05 13:35 ` Marcelo Tosatti [this message]
2011-12-05 13:46 ` Jan Kiszka
2011-12-05 12:58 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205133544.GA32052@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).