From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXy5Y-0002aJ-GM for qemu-devel@nongnu.org; Tue, 06 Dec 2011 11:41:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXy5S-0000Ja-V1 for qemu-devel@nongnu.org; Tue, 06 Dec 2011 11:41:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXy5S-0000JU-OF for qemu-devel@nongnu.org; Tue, 06 Dec 2011 11:41:46 -0500 Date: Tue, 6 Dec 2011 14:40:24 -0200 From: Marcelo Tosatti Message-ID: <20111206164024.GB18350@amt.cnet> References: <1321334931-26087-1-git-send-email-wdongxu@linux.vnet.ibm.com> <20111206124843.GA14426@amt.cnet> <4EDE11C4.2040202@redhat.com> <20111206145316.GA17987@amt.cnet> <20111206150610.GA18056@amt.cnet> <4EDE32D7.307@redhat.com> <20111206163503.GA18350@amt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111206163503.GA18350@amt.cnet> Subject: Re: [Qemu-devel] [PATCH v5] block:add-cow file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: shuming@linux.vnet.ibm.com, Dong Xu Wang , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Tue, Dec 06, 2011 at 02:35:03PM -0200, Marcelo Tosatti wrote: > > Right, we can probably generalise the qcow2 code and make it available > > for other drivers as well. > > Hum, generalising sounds overly complicated (and there is a time > constraint to this). IMHO a cache internal to add-cow.c just to avoid > reading the entire bitmap would do the trick. (and writes must go through the cache too, of course).