From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Joerg.Roedel@amd.com>) id 1RYKzX-0002xF-7I
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 12:09:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Joerg.Roedel@amd.com>) id 1RYKzS-0008VX-Er
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 12:09:11 -0500
Received: from db3ehsobe005.messaging.microsoft.com ([213.199.154.143]:36176
	helo=DB3EHSOBE005.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Joerg.Roedel@amd.com>) id 1RYKzS-0008VM-2N
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 12:09:06 -0500
Date: Wed, 7 Dec 2011 17:38:42 +0100
From: Joerg Roedel <joerg.roedel@amd.com>
Message-ID: <20111207163842.GC29680@amd.com>
References: <CALRxmdDS4qas9fyHXeDVw2e_yMCTqzMi6VXUF-q+eYwgMwg7tw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <CALRxmdDS4qas9fyHXeDVw2e_yMCTqzMi6VXUF-q+eYwgMwg7tw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] vfio / iommu domain attributes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Yoder <b08248@gmail.com>
Cc: chrisw@sous-sol.org, Alexey Kardashevskiy <aik@au1.ibm.com>, kvm@vger.kernel.org, pmac@au1.ibm.com, linux-pci@vger.kernel.org, konrad.wilk@oracle.com, qemu-devel@nongnu.org, iommu@lists.linux-foundation.org, agraf@suse.de, aafabbri@cisco.com, B08248@freescale.com, Alex Williamson <alex.williamson@redhat.com>, avi@redhat.com, David Gibson <david@gibson.dropbear.id.au>, dwg@au1.ibm.com, B07421@freescale.com, benve@cisco.com

On Wed, Dec 07, 2011 at 09:54:39AM -0600, Stuart Yoder wrote:
> Alex, Alexey I'm wondering if you've had any new thoughts on this over
> the last week.
>=20
> For Freescale, our iommu domain attributes would look something like:
>     -domain iova base address
>     -domain iova window size

I agree with that.

>     -domain enable/disable
>     -number of subwindows
>     -operation mapping table index
>     -stash destination CPU
>     -stash target (cache=E2=80=93 L1, L2, L3)

Why does the user of the IOMMU-API need to have control over these
things?

> These are all things that need to be set by the creator of the domain.
>=20
> Since the domain attributes are going to be so different for each platf=
orm does
> it make sense to define a new iommu_ops call back that just takes a voi=
d pointer
> that can be implemented in a platform specific way?   For example:
>=20
>     struct iommu_ops {
>         [cut]
>         int (*domain_set_attrs)(struct iommu_domain *domain,
>                               void *attrs);
>         int (*domain_get_attrs)(struct iommu_domain *domain,
>                               void *attrs);
>     }

A void pointer is certainly the worst choice for an interface. I think
it is better to have at least a set of common attributes. Somthing like
this:

iommu_domain_set_attr(struct iommu_domain *domain, enum attr_type, void *=
data)
iommu_domain_get_attr(struct iommu_domain *domain, enum attr_type, void *=
data)

The iova base/size options make sense for more IOMMUs than just
Freescale. For example it would allow to manage GART-like IOMMUs with
the IOMMU-API too.


	Joerg

--=20
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 4=
3632