qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command
Date: Thu, 8 Dec 2011 16:52:58 -0200	[thread overview]
Message-ID: <20111208165258.17ab95f7@doriath> (raw)

This is basically suspend to disk on a Linux guest.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---

This is an RFC because I did it as simple as possible and I'm open to
suggestions...

Now, while testing this or even "echo disk > /sys/power/state" I get several
funny results. Some times qemu just dies after printing that message:

 "Guest moved used index from 20151 to 1"

Some times it doesn't die, but I'm unable to log into the guest: I type
username & password but the terminal kind of locks (the shell doesn't run).

Some times it works...

 qapi-schema-guest.json     |   11 +++++++++++
 qga/guest-agent-commands.c |   19 +++++++++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
index fde5971..2c5bbcf 100644
--- a/qapi-schema-guest.json
+++ b/qapi-schema-guest.json
@@ -215,3 +215,14 @@
 ##
 { 'command': 'guest-fsfreeze-thaw',
   'returns': 'int' }
+
+##
+# @guest-hibernate
+#
+# Save RAM contents to disk and powerdown the guest.
+#
+# Notes: This command doesn't return on success.
+#
+# Since: 1.1
+##
+{ 'command': 'guest-hibernate' }
diff --git a/qga/guest-agent-commands.c b/qga/guest-agent-commands.c
index 6da9904..9dd4060 100644
--- a/qga/guest-agent-commands.c
+++ b/qga/guest-agent-commands.c
@@ -550,6 +550,25 @@ int64_t qmp_guest_fsfreeze_thaw(Error **err)
 }
 #endif
 
+#define LINUX_SYS_STATE_FILE "/sys/power/state"
+
+void qmp_guest_hibernate(Error **err)
+{
+    int fd;
+
+    fd = open(LINUX_SYS_STATE_FILE, O_WRONLY);
+    if (fd < 0) {
+        error_set(err, QERR_OPEN_FILE_FAILED, LINUX_SYS_STATE_FILE);
+        return;
+    }
+
+    if (write(fd, "disk", 4) < 0) {
+        error_set(err, QERR_UNDEFINED_ERROR);
+    }
+
+    close(fd);
+}
+
 /* register init/cleanup routines for stateful command groups */
 void ga_command_state_init(GAState *s, GACommandState *cs)
 {
-- 
1.7.8.110.g4cb5d1.dirty

             reply	other threads:[~2011-12-08 18:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 18:52 Luiz Capitulino [this message]
2011-12-08 19:07 ` [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command Daniel P. Berrange
2011-12-08 19:16   ` Luiz Capitulino
2011-12-08 23:11 ` Andreas Färber
2011-12-09  1:14 ` Michael Roth
2011-12-09 12:23   ` Luiz Capitulino
2011-12-09  3:18 ` Michael Roth
2011-12-09 12:22   ` Luiz Capitulino
2011-12-09 12:35     ` Amit Shah
2011-12-09  5:01 ` Amit Shah
2011-12-11 10:00 ` Dor Laor
2011-12-12 12:39   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111208165258.17ab95f7@doriath \
    --to=lcapitulino@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).