qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command
Date: Fri, 9 Dec 2011 18:05:29 +0530	[thread overview]
Message-ID: <20111209123529.GG2464@amit-x200.redhat.com> (raw)
In-Reply-To: <20111209102225.18dd2d42@doriath>

On (Fri) 09 Dec 2011 [10:22:25], Luiz Capitulino wrote:
> On Thu, 08 Dec 2011 21:18:00 -0600
> Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> 
> > On 12/08/2011 12:52 PM, Luiz Capitulino wrote:
> > > This is basically suspend to disk on a Linux guest.
> > >
> > > Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> > > ---
> > >
> > > This is an RFC because I did it as simple as possible and I'm open to
> > > suggestions...
> > >
> > > Now, while testing this or even "echo disk>  /sys/power/state" I get several
> > > funny results. Some times qemu just dies after printing that message:
> > >
> > >   "Guest moved used index from 20151 to 1"
> > >
> > > Some times it doesn't die, but I'm unable to log into the guest: I type
> > > username&  password but the terminal kind of locks (the shell doesn't run).
> > >
> > > Some times it works...

...

> > It doesn't seem to tell us much...but there's a bunch of successful 
> > reads before the final virtio_queue_notify, and that notify takes quite 
> > a bit longer than the previous ones. I can only speculate at this point, 
> > but I would guess this is when the guest has completed loading the saved 
> > memory from disk and it attempting to restore the previous state..
> > 
> > In the kernel there's a virtio_pci_suspend() PM callback that seems to 
> > get called around this time and restores the PCI config from 
> > virtio_pci_resume(). Could that be switching us to an older vring and 
> > throwing the QEMU side out of whack?
> 
> Not sure. But Amit has confirmed that it's a virtio bug and he's working
> on it. Right Amit?

Yes.  You can try the series at

https://lkml.org/lkml/2011/12/6/479

in the guest kernel to see it all work.

		Amit

  reply	other threads:[~2011-12-09 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 18:52 [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command Luiz Capitulino
2011-12-08 19:07 ` Daniel P. Berrange
2011-12-08 19:16   ` Luiz Capitulino
2011-12-08 23:11 ` Andreas Färber
2011-12-09  1:14 ` Michael Roth
2011-12-09 12:23   ` Luiz Capitulino
2011-12-09  3:18 ` Michael Roth
2011-12-09 12:22   ` Luiz Capitulino
2011-12-09 12:35     ` Amit Shah [this message]
2011-12-09  5:01 ` Amit Shah
2011-12-11 10:00 ` Dor Laor
2011-12-12 12:39   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111209123529.GG2464@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).