From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaTbp-0006IN-8L for qemu-devel@nongnu.org; Tue, 13 Dec 2011 09:45:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaTbk-0006MH-KR for qemu-devel@nongnu.org; Tue, 13 Dec 2011 09:45:33 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:53457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaTbk-0006Lo-Hf for qemu-devel@nongnu.org; Tue, 13 Dec 2011 09:45:28 -0500 Received: from /spool/local by e4.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Dec 2011 09:45:26 -0500 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBDEXqEk2576502 for ; Tue, 13 Dec 2011 09:33:53 -0500 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBDEXVUt019595 for ; Tue, 13 Dec 2011 07:33:33 -0700 Date: Tue, 13 Dec 2011 08:33:27 -0600 From: Adam Litke Message-ID: <20111213143327.GA2987@us.ibm.com> References: <1323275584-8751-1-git-send-email-agl@us.ibm.com> <4EE68846.4010101@us.ibm.com> <4EE6907C.3010901@linux.vnet.ibm.com> <20111213102318.6f3904bc@doriath> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111213102318.6f3904bc@doriath> Subject: Re: [Qemu-devel] [PATCH] build: Cleanup qga make output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Michael Roth , qemu-devel@nongnu.org On Tue, Dec 13, 2011 at 10:23:18AM -0200, Luiz Capitulino wrote: > On Mon, 12 Dec 2011 17:38:36 -0600 > Michael Roth wrote: > > > On 12/12/2011 05:03 PM, Anthony Liguori wrote: > > > On 12/07/2011 10:33 AM, Adam Litke wrote: > > >> Currently the make variable qapi-dir refers to the qapi-generated > > >> directory in > > >> absolute terms. This causes the harmless but ugly make output below. By > > >> changing this variable to the relative path the output conforms to the > > >> norm and > > >> the build works fine. > > >> > > >> Before patch: > > >> CC /home/aglitke/src/qemu/qapi-generated/qga-qapi-types.o > > >> CC /home/aglitke/src/qemu/qapi-generated/qga-qapi-visit.o > > >> CC /home/aglitke/src/qemu/qapi-generated/qga-qmp-marshal.o > > >> After patch: > > >> CC qapi-generated/qga-qapi-types.o > > >> CC qapi-generated/qga-qapi-visit.o > > >> CC qapi-generated/qga-qmp-marshal.o > > > > > > This was supposedly to fix a build issue that I was never able to > > > reproduce. I think Luiz could reproduce it though. Luiz, could you try > > > out Adam's patch and confirm it breaks for you? > > It doesn't :( I also tried to reproduce again with -rc4 (which was the > version I was getting it) but it doesn't happen anymore. > > > I think that was Stefano: > > > > http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg02752.html > > > > Stefano had a patch that fixed a build breakage he saw with dirty > > directories by setting: > > > > qapi-dir := $(SRC_DIR)/qapi-generated > > > > That patch ended up breaking the build for others, however, and was > > reverted. > > > > This patch was an improvement on the original, but we'd all agreed that > > it wasn't necessary since we don't support working around issues related > > to dirty directories. I am lacking some context here. I am confused how a dirty directory could change the output in this way. > What kind of issue? I'm 100% certain that my tree was clean, the only > thing I did not do was to clone it again. > > We have had races when building the qapi in the past, maybe that's the > problem and commit 9b12940 makes it less likely. > > We could revert it and wait for the problem to happen again... I would be fine with doing whatever is least likely to cause anyone else problems. I wouldn't want to break the actual build just to make the output look nice. > > > > > So if it's ugly, we can safely drop it. > > > > > > > > Regards, > > > > > > Anthony Liguori > > > > > >> > > >> Signed-off-by: Adam Litke > > >> --- > > >> Makefile | 2 +- > > >> 1 files changed, 1 insertions(+), 1 deletions(-) > > >> > > >> diff --git a/Makefile b/Makefile > > >> index 301c75e..7c93739 100644 > > >> --- a/Makefile > > >> +++ b/Makefile > > >> @@ -168,7 +168,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) > > >> $(tools-obj-y) > > >> test-coroutine: test-coroutine.o qemu-timer-common.o async.o > > >> $(coroutine-obj-y) $(tools-obj-y) > > >> > > >> $(qapi-obj-y): $(GENERATED_HEADERS) > > >> -qapi-dir := $(BUILD_DIR)/qapi-generated > > >> +qapi-dir := qapi-generated > > >> test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I > > >> $(qapi-dir) > > >> qemu-ga$(EXESUF): LIBS = $(LIBS_QGA) > > >> > > > > > > > > > -- Adam Litke IBM Linux Technology Center