From: Paul Brook <paul@codesourcery.com>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
"dvaleev@suse.com" <dvaleev@suse.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts
Date: Wed, 14 Dec 2011 02:24:17 +0000 [thread overview]
Message-ID: <201112140224.18288.paul@codesourcery.com> (raw)
In-Reply-To: <285BCAC5-E270-4B49-9DC5-081A79691BE3@suse.de>
> >> IIRC mmap'ing files would break with 32-on-64, but I'd have to check up
> >> on the details. I ended up passing MAP_32BIT to all linux-user mmap
> >> calla for 32-on-x86_64, but that doesn't work with -R.
> >
> > Hmm, I thought we'd fixed that. It's the reason h2g_valid exists.
> >
> > Either way it should definitely work with -R. I specifically added that
> > to avoid problems with the host mmap picking inconvenient addresse.
> >
> > MAP_32BIT is an unconsionable hack, and doesn't exist on other 64-bit
> > hosts.
>
> Yes, I agree. I just sat down once more and checked if I could get it
> working with -R and everything seems fine so far.
>
> Is there any particular reason we're not reserving all of the possible 32
> bit address space for 32-on-64 guests? The way it's today with the default
> being completely broken and -R fixing everything if you give it a large
> enough value is ... suboptimal.
-R doesn't actually fix everything :-)
In particular if you use ulimit -v then there's a good chance it will break
completely. Having said that, it's not hard to check ulimit -v first.
I still think the current config should work. The automagical guest_base
isn't quite as reliable as -R (the guest and host spaces probably overlap) but
it should be comparable to 32-on-32.
If we do default to -R 4G for 32-on-64, then there's a good argument for
enabling it by default for all combinations. For 32-bit hosts you can either
try to guess the size of the host user address space, or just start by trying
3G and if that doesn't work progressively fall back to 2G, 1G, then current
behavior.
For 64-on-64 maybe pick a large value, remebering that the reservation
probably isn't completely free.
Paul
next prev parent reply other threads:[~2011-12-14 2:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 21:36 [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts Alexander Graf
2011-12-13 0:55 ` Richard Henderson
2011-12-13 1:05 ` Alexander Graf
2011-12-13 6:19 ` Paul Brook
2011-12-13 7:45 ` Alexander Graf
2011-12-13 16:31 ` Paul Brook
2011-12-13 21:59 ` Alexander Graf
2011-12-14 0:30 ` Paul Brook
2011-12-14 1:43 ` Alexander Graf
2011-12-14 2:24 ` Paul Brook [this message]
2011-12-20 16:17 ` Peter Maydell
2011-12-20 16:29 ` Alexander Graf
2011-12-20 16:33 ` Peter Maydell
2011-12-20 16:43 ` Alexander Graf
2011-12-14 8:53 ` Peter Maydell
2011-12-14 12:04 ` Paul Brook
2011-12-14 12:21 ` Peter Maydell
2011-12-14 17:34 ` Paul Brook
2011-12-13 8:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112140224.18288.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=dvaleev@suse.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).