From: Stefan Hajnoczi <stefanha@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci
Date: Thu, 15 Dec 2011 08:17:29 +0000 [thread overview]
Message-ID: <20111215081729.GB26425@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1323907817-27342-1-git-send-email-aliguori@us.ibm.com>
On Wed, Dec 14, 2011 at 06:10:17PM -0600, Anthony Liguori wrote:
> Untested, but seemingly obvious and hard to screw up..
Sounds like a challenge so let's take a look...
> -void usb_ohci_init_pci(struct PCIBus *bus, int devfn)
> +USBBus *usb_ohci_init_pci(struct PCIBus *bus, int devfn)
> {
> - pci_create_simple(bus, devfn, "pci-ohci");
> + PCIDevice *dev = pci_create_simple(bus, devfn, "pci-ohci");
> + OHCIPCIState *ohci = DO_UPCAST(OHCIPCIState, pci_dev, dev);
> +
> + return &ohci->state.bus
Missing semicolon.
Stefan
next prev parent reply other threads:[~2011-12-15 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 0:10 [Qemu-devel] [PATCH] usb-ohci: return USBBus in usb_ohci_init_pci Anthony Liguori
2011-12-15 8:17 ` Stefan Hajnoczi [this message]
2011-12-15 15:10 ` Anthony Liguori
2011-12-15 16:36 ` Gerd Hoffmann
2011-12-15 16:49 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215081729.GB26425@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).