From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbEAl-0005Yv-9r for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbEAe-0005cn-Bm for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:28:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbEAe-0005cB-28 for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:28:36 -0500 Date: Thu, 15 Dec 2011 08:40:08 -0200 From: Marcelo Tosatti Message-ID: <20111215104008.GA8222@amt.cnet> References: <1323784351-25531-1-git-send-email-stefanha@linux.vnet.ibm.com> <1323784351-25531-3-git-send-email-stefanha@linux.vnet.ibm.com> <4EE8A9F3.8080804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EE8A9F3.8080804@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/9] block: add BlockJob interface for long-running operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Luiz Capitulino , Stefan Hajnoczi , qemu-devel@nongnu.org On Wed, Dec 14, 2011 at 02:51:47PM +0100, Kevin Wolf wrote: > Am 13.12.2011 14:52, schrieb Stefan Hajnoczi: > > Signed-off-by: Stefan Hajnoczi > > --- > > block_int.h | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 83 insertions(+), 0 deletions(-) > > Why are these functions static inline in the header instead of being > implemented in block.c? > > The other thing I was going to ask, but don't really know to which patch > I should reply, is whether we need to take care of bdrv_close/delete > while a block job is still running. What happens if you unplug a device > that is being streamed? There is an additional reference, its not deleted until the operation completes. Or at least it should be like that, Stefan?