From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RchF8-0004mZ-1O for qemu-devel@nongnu.org; Mon, 19 Dec 2011 12:43:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RchF6-0004Hl-Do for qemu-devel@nongnu.org; Mon, 19 Dec 2011 12:43:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RchF6-0004Hf-4e for qemu-devel@nongnu.org; Mon, 19 Dec 2011 12:43:16 -0500 Date: Mon, 19 Dec 2011 17:43:07 +0000 From: "Daniel P. Berrange" Message-ID: <20111219174307.GB2558@redhat.com> References: <4EEBF3EA.3040401@codemonkey.ws> <20111217082958.GJ2520@amd.home.annexia.org> <4EECB1B0.7050404@codemonkey.ws> <4EECB3C5.6060608@codemonkey.ws> <20111217152514.GM2520@amd.home.annexia.org> <4EECC227.4060904@codemonkey.ws> <20111217164956.GA16848@morn.localdomain> <20111219103101.GB27938@redhat.com> <4EEF7595.7060301@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4EEF7595.7060301@codemonkey.ws> Subject: Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "seabios@seabios.org" , "Richard W.M. Jones" , qemu-devel@nongnu.org, Max Filippov , Kevin O'Connor , Avi Kivity , Amit Shah , Gerd Hoffmann On Mon, Dec 19, 2011 at 11:34:13AM -0600, Anthony Liguori wrote: > On 12/19/2011 04:31 AM, Daniel P. Berrange wrote: > >On Sat, Dec 17, 2011 at 11:49:56AM -0500, Kevin O'Connor wrote: > >>On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > >>>On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > >>>>On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > >>>>>I've even further narrowed it down to the presents or lack of '-vga > >>>>>cirrus'. If you add '-vga cirrus' to the above command line, the > >>>>>guest will boot successfully. > >>>> > >>>>Confirmed: Adding -vga cirrus to the command line cures it too. > >>>> > >>>>That's a strange one :-) > >>> > >>>vga sticks out a bit because it's one of the few places where we > >>>treat device memory as ram as a performance optimization. > >>> > >>>The only time vga has been touched in between v0.15 and v1.0 was > >>>during the introduction of the memory API. > >>> > >>>It's this commit: > >>> > >>>commit d67c3f2cd92aed2247bfa8a9da61a902b7b2ff09 > >>>Author: Gerd Hoffmann > >>>Date: Wed Aug 10 17:34:13 2011 +0200 > >>> > >>> seabios: update to master > >> > >>This looks like the same issue reported at: > >> > >>http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00029.html > >> > >>The SeaBIOS fix for this was in rel-1.6.3.1 - but that didn't make > >>QEmu 1.0. Does the problem go away if you upgrade to the newer > >>SeaBIOS version? > > > >Sigh, we really need to be better about updating SeaBIOS in QEMU before > >release. We had plenty of time to pull in a newer SeaBIOS before 1.0 > >that would have fixed this :-( > > 1.6.3.1 was released on Nov 24th, which was actually after the soft > feature freeze. We could have pulled 1.6.3 which was Oct 4th but > updating the BIOS always results in some interesting things > happening so it's not something I like to do unless we have to. > > I'd rather have known that this functionality broken before that > commit event went in to begin with than allowing it to remain broken > until we happened to update past the bug. > > >We've had multiple releases now where > >functionality is broken due to QEMU shipping with an older SeaBIOS > >release than is available upstream. > > I think the real issue here is testing. -nodefconfig -nodefaults is > used by both libguestfs and libvirt but I'd wager to say that almost > noone tests it in QEMU. I had actually discovered & pointed out this flaw on qemu-devel back in September, and Kevin had the seabios fix by Oct http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00029.html I hadn't raised it again, because I had mistakenly assumed QEMU will automatically pull in the newer SeaBios release before 1.0 came out. I could have more aggresively bugged people on qemu-devel to update SeaBios, but given your point above about not wanting to rebase Seabios its not clear that would have helped sort this out before 1.0 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|