From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: refuse SG_IO requests with scsi=off
Date: Fri, 30 Dec 2011 11:45:33 +0000 [thread overview]
Message-ID: <20111230114533.GE1740@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1324651143-5247-1-git-send-email-pbonzini@redhat.com>
On Fri, Dec 23, 2011 at 03:39:03PM +0100, Paolo Bonzini wrote:
> QEMU does have a "scsi" option (to be used like -device
> virtio-blk-pci,drive=foo,scsi=off). However, it only
> masks the feature bit, and does not reject the command
> if a malicious guest disregards the feature bits and
> issues a request.
>
> Without this patch, using scsi=off does not protect you
> from CVE-2011-4127.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/virtio-blk.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
I checked that guest_features cannot have SCSI enabled when the host
wishes to prohibit SCSI.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-12-30 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 14:39 [Qemu-devel] [PATCH] virtio-blk: refuse SG_IO requests with scsi=off Paolo Bonzini
2011-12-30 11:45 ` Stefan Hajnoczi [this message]
2012-01-05 10:05 ` Paolo Bonzini
2012-01-13 15:56 ` Paolo Bonzini
2012-01-13 16:54 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230114533.GE1740@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).