qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Fix test for supported host CPU type
Date: Tue, 3 Jan 2012 10:50:58 +0000	[thread overview]
Message-ID: <20120103105058.GA28684@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1324732045-5516-1-git-send-email-peter.maydell@linaro.org>

On Sat, Dec 24, 2011 at 01:07:25PM +0000, Peter Maydell wrote:
> The test for whether the host CPU is supported had several problems:
>  * the attempt to fall back to TCI was done as a duplicate
>    test, very late (so "--cpu foo" would fail early but "--cpu unicore32"
>    would fail late, differently, and after configure had already
>    printed a lot of output)
>  * a number of CPUs only supported as guests were included in the
>    list of CPUs we would accept as valid hosts, which would result
>    in a late compile failure on those systems rather than a
>    configure failure or fallback to TCI
>  * bailing out for an unsupported CPU happened before the main
>    option parsing, so "configure --help" wouldn't work
> 
> Fix these by folding the setting of ARCH into the first test for
> supported host CPU, removing spurious guest-only CPU names from it,
> and moving the "fall back to TCI" code earlier.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure |   44 +++++++++++++++++++++-----------------------
>  1 files changed, 21 insertions(+), 23 deletions(-)

Thanks, applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/commits/trivial-patches-next

Stefan

      reply	other threads:[~2012-01-03 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-24 13:07 [Qemu-devel] [PATCH] configure: Fix test for supported host CPU type Peter Maydell
2012-01-03 10:50 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120103105058.GA28684@stefanha-thinkpad.localdomain \
    --to=stefanha@gmail.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).