From: Luiz Capitulino <lcapitulino@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string
Date: Tue, 3 Jan 2012 17:36:12 -0200 [thread overview]
Message-ID: <20120103173612.49e8d6a0@doriath> (raw)
In-Reply-To: <20111230115614.GF1740@stefanha-thinkpad.localdomain>
On Fri, 30 Dec 2011 11:56:14 +0000
Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Fri, Dec 23, 2011 at 08:34:38PM +0100, Stefan Weil wrote:
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > ---
> > test-qmp-input-visitor.c | 7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
>
> Although we're not strictly implementing printf format strings it's
> close enough that this seems worth having. If we ever introduce format
> specifiers that have a different meaning under printf then we need to
> rethink this.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Applied to the qmp branch, thanks Stefans.
prev parent reply other threads:[~2012-01-03 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 19:34 [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string Stefan Weil
2011-12-30 11:56 ` Stefan Hajnoczi
2012-01-03 19:36 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103173612.49e8d6a0@doriath \
--to=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).