[Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string

[Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string

[Stefan Weil]

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 test-qmp-input-visitor.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/test-qmp-input-visitor.c b/test-qmp-input-visitor.c
index 1f3ab03..bc410c6 100644
--- a/test-qmp-input-visitor.c
+++ b/test-qmp-input-visitor.c
@@ -38,8 +38,9 @@ static void visitor_input_teardown(TestInputVisitorData *data,
 /* This is provided instead of a test setup function so that the JSON
    string used by the tests are kept in the test functions (and not
    int main()) */
-static Visitor *visitor_input_test_init(TestInputVisitorData *data,
-                                        const char *json_string, ...)
+static GCC_FMT_ATTR(2, 3)
+Visitor *visitor_input_test_init(TestInputVisitorData *data,
+                                 const char *json_string, ...)
 {
     Visitor *v;
     va_list ap;
@@ -66,7 +67,7 @@ static void test_visitor_in_int(TestInputVisitorData *data,
     Error *errp = NULL;
     Visitor *v;
 
-    v = visitor_input_test_init(data, "%d", value);
+    v = visitor_input_test_init(data, "%" PRId64, value);
 
     visit_type_int(v, &res, NULL, &errp);
     g_assert(!error_is_set(&errp));
-- 
1.7.2.5

Re: [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string

[Stefan Hajnoczi]

On Fri, Dec 23, 2011 at 08:34:38PM +0100, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  test-qmp-input-visitor.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)

Although we're not strictly implementing printf format strings it's
close enough that this seems worth having.  If we ever introduce format
specifiers that have a different meaning under printf then we need to
rethink this.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Re: [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string

[Luiz Capitulino]

On Fri, 30 Dec 2011 11:56:14 +0000
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Fri, Dec 23, 2011 at 08:34:38PM +0100, Stefan Weil wrote:
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > ---
> >  test-qmp-input-visitor.c |    7 ++++---
> >  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> Although we're not strictly implementing printf format strings it's
> close enough that this seems worth having.  If we ever introduce format
> specifiers that have a different meaning under printf then we need to
> rethink this.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Applied to the qmp branch, thanks Stefans.