From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiA9j-0006eE-Aa for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:36:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiA9h-0006Br-UT for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:36:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiA9h-0006Bh-Nt for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:36:17 -0500 Date: Tue, 3 Jan 2012 17:36:12 -0200 From: Luiz Capitulino Message-ID: <20120103173612.49e8d6a0@doriath> In-Reply-To: <20111230115614.GF1740@stefanha-thinkpad.localdomain> References: <1324668878-23590-1-git-send-email-sw@weilnetz.de> <20111230115614.GF1740@stefanha-thinkpad.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: Add missing gcc format attribute and fix format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Stefan Weil , qemu-devel@nongnu.org On Fri, 30 Dec 2011 11:56:14 +0000 Stefan Hajnoczi wrote: > On Fri, Dec 23, 2011 at 08:34:38PM +0100, Stefan Weil wrote: > > Signed-off-by: Stefan Weil > > --- > > test-qmp-input-visitor.c | 7 ++++--- > > 1 files changed, 4 insertions(+), 3 deletions(-) > > Although we're not strictly implementing printf format strings it's > close enough that this seems worth having. If we ever introduce format > specifiers that have a different meaning under printf then we need to > rethink this. > > Reviewed-by: Stefan Hajnoczi Applied to the qmp branch, thanks Stefans.