From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiQdS-0002JD-Db for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:12:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiQdQ-0000CP-R4 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:12:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiQdQ-0000CL-JI for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:12:04 -0500 Date: Wed, 4 Jan 2012 11:11:59 -0200 From: Luiz Capitulino Message-ID: <20120104111159.67d1d1e5@doriath> In-Reply-To: <20120104105911.7e8ca4e4@doriath> References: <1323784351-25531-1-git-send-email-stefanha@linux.vnet.ibm.com> <1323784351-25531-6-git-send-email-stefanha@linux.vnet.ibm.com> <20120104105911.7e8ca4e4@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/9] qmp: add block_stream command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Marcelo Tosatti , Stefan Hajnoczi , qemu-devel@nongnu.org By the way, most of my review comments applies to the other commands being added in this series: - Use verbs and separate word with hyphens - Follow the documentation syntax (see other commands for examples) - Use the hmp_handle_error() helper - Drop any SQMP/EQMP documentation