From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiX2C-0002mx-4a for qemu-devel@nongnu.org; Wed, 04 Jan 2012 15:02:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiX2A-0000NL-Tw for qemu-devel@nongnu.org; Wed, 04 Jan 2012 15:02:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiX2A-0000NH-L3 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 15:02:02 -0500 Date: Wed, 4 Jan 2012 18:01:58 -0200 From: Luiz Capitulino Message-ID: <20120104180158.49a1e01c@doriath> In-Reply-To: <1325698703-15370-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1325698703-15370-1-git-send-email-stefanha@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] qerror: proper errors for qmp_block_resize() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org On Wed, 4 Jan 2012 17:38:20 +0000 Stefan Hajnoczi wrote: > The block resize command returns undefined errors if things go wrong. This is > bad since users will have no chance to understand what failed. Oops, this introduces a segfault try "block_resize ide1-cd0 100" in the monitor and you'll see it. > > Patch 3 makes qmp_block_resize() use meaningful errors. We introduce new > qerrors for ENOMEDIUM and EACCES since nothing exists yet. > > When doing this I noticed that qerror definitions and table entries are not in > alphabetical order as required by the comments in qerror.h and qerror.c. > That's not a surprise since there is no automated way to enforce this. I'm not > sure whether this requirement is useful or not in the first place, but felt > guilty creating more mess. So I've restored alphabetical order and added a > script to verify that the requirement is met in Patches 1 and 2. > > Stefan Hajnoczi (3): > qerror: add check-qerror.sh to verify alphabetical order > qerror: restore alphabetical order over qerrors > block: use proper qerrors in qmp_block_resize > > blockdev.c | 26 +++++++++---- > qerror.c | 91 +++++++++++++++++++++++++--------------------- > qerror.h | 78 +++++++++++++++++++++------------------ > scripts/check-qerror.sh | 22 +++++++++++ > 4 files changed, 131 insertions(+), 86 deletions(-) > create mode 100755 scripts/check-qerror.sh >