From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Rj6MG-00051Z-P8
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:45:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Rj6MF-0005iI-Hx
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:45:08 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:50677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Rj6MF-0005i3-5D
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:45:07 -0500
Received: by eekb45 with SMTP id b45so1070452eek.4
	for <qemu-devel@nongnu.org>; Fri, 06 Jan 2012 01:45:06 -0800 (PST)
Date: Fri, 6 Jan 2012 08:31:16 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20120106083116.GA18217@stefanha-thinkpad.localdomain>
References: <1325522015-503-1-git-send-email-avi@redhat.com>
	<1325522015-503-9-git-send-email-avi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1325522015-503-9-git-send-email-avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED,
 NOTDIRTY} to MemoryRegions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 02, 2012 at 06:33:27PM +0200, Avi Kivity wrote:
> These aren't real
> regions, since they are never added to the memory hierarchy, but they
> allow reuse of the dispatch functionality.

This would be great as a comment...

> +extern struct MemoryRegion io_mem_ram;
> +extern struct MemoryRegion io_mem_rom;
> +extern struct MemoryRegion io_mem_unassigned;
> +extern struct MemoryRegion io_mem_notdirty;

^^ here, so future readers will know their purpose without looking at
git logs.

Stefan