From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
Dr David Alan Gilbert <davidagilbert@uk.ibm.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-nbd: drop loop which can never loop
Date: Fri, 6 Jan 2012 15:10:19 +0000 [thread overview]
Message-ID: <20120106151019.GA27565@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1325769367-32267-1-git-send-email-stefanha@linux.vnet.ibm.com>
On Thu, Jan 05, 2012 at 01:16:07PM +0000, Stefan Hajnoczi wrote:
> For some reason nbd_client_thread() has a do..while loop which can never
> loop, the condition is bogus because we would take a goto instead. Drop
> the loop.
>
> Reported-by: Dr David Alan Gilbert <davidagilbert@uk.ibm.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> qemu-nbd.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
Applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/commits/trivial-patches-next
Stefan
prev parent reply other threads:[~2012-01-06 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 13:16 [Qemu-devel] [PATCH] qemu-nbd: drop loop which can never loop Stefan Hajnoczi
2012-01-05 13:29 ` Paolo Bonzini
2012-01-05 14:22 ` Stefan Hajnoczi
2012-01-06 15:10 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106151019.GA27565@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=davidagilbert@uk.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).