From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjBR3-0005ef-7O for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:10:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjBR1-0006yg-Q4 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:10:25 -0500 Date: Fri, 6 Jan 2012 15:10:19 +0000 From: Stefan Hajnoczi Message-ID: <20120106151019.GA27565@stefanha-thinkpad.localdomain> References: <1325769367-32267-1-git-send-email-stefanha@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325769367-32267-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-nbd: drop loop which can never loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org, Dr David Alan Gilbert On Thu, Jan 05, 2012 at 01:16:07PM +0000, Stefan Hajnoczi wrote: > For some reason nbd_client_thread() has a do..while loop which can never > loop, the condition is bogus because we would take a goto instead. Drop > the loop. > > Reported-by: Dr David Alan Gilbert > Signed-off-by: Stefan Hajnoczi > --- > qemu-nbd.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) Applied to the trivial patches -next tree: https://github.com/stefanha/qemu/commits/trivial-patches-next Stefan