From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjcth-00050G-Kf for qemu-devel@nongnu.org; Sat, 07 Jan 2012 15:29:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rjctg-0003yU-8D for qemu-devel@nongnu.org; Sat, 07 Jan 2012 15:29:49 -0500 Received: from hall.aurel32.net ([88.191.126.93]:44007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjctf-0003yO-Qv for qemu-devel@nongnu.org; Sat, 07 Jan 2012 15:29:48 -0500 Date: Sat, 7 Jan 2012 21:29:44 +0100 From: Aurelien Jarno Message-ID: <20120107202944.GE20302@volta.aurel32.net> References: <1325713809-10461-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1325713809-10461-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] sm501: Fix size of color_reg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Shin-ichiro Kawasaki , qemu-devel@nongnu.org On Wed, Jan 04, 2012 at 10:50:09PM +0100, Stefan Weil wrote: > color_reg is expected to hold 32 bit values, so it was too small. > > This bug was reported by coverity: > > hw/sm501.c:624: > result_independent_of_operands: > color_reg >> 16 is 0 regardless of the values of its operands. > This occurs as the bitwise first operand of '&'. > > Cc: Shin-ichiro Kawasaki > Signed-off-by: Stefan Weil > --- > hw/sm501.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Thanks, applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net