From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjdO4-0006jK-16 for qemu-devel@nongnu.org; Sat, 07 Jan 2012 16:01:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjdO2-0007tH-SR for qemu-devel@nongnu.org; Sat, 07 Jan 2012 16:01:11 -0500 Received: from hall.aurel32.net ([88.191.126.93]:57409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjdO2-0007t8-Nm for qemu-devel@nongnu.org; Sat, 07 Jan 2012 16:01:10 -0500 Date: Sat, 7 Jan 2012 22:01:09 +0100 From: Aurelien Jarno Message-ID: <20120107210108.GC20942@hall.aurel32.net> References: <1325967416-1760-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Sat, Jan 07, 2012 at 08:36:12PM +0000, Blue Swirl wrote: > On Sat, Jan 7, 2012 at 20:16, Aurelien Jarno wrote: > > Fix .rel.plt sections in the output to not only include .rel.plt > > sections from the input but also the .rel.iplt sections and to define > > the hidden symbols __rel_iplt_start and __rel_iplt_end around > > .rel.iplt as otherwise we get undefined references to these when > > linking statically to a multiarch enabled libc (using STT_GNU_IFUNC). > > > > Blue Swirl > > Signed-off-by: Aurelien Jarno > > --- > >  sparc.ld |   16 ++++++++++++++-- > >  1 files changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/sparc.ld b/sparc.ld > > index 56efe34..e52c3d2 100644 > > --- a/sparc.ld > > +++ b/sparc.ld > > @@ -37,8 +37,20 @@ SECTIONS > >   .rela.fini     : { *(.rela.fini)      } > >   .rel.bss       : { *(.rel.bss)                } > >   .rela.bss      : { *(.rela.bss)               } > > -  .rel.plt       : { *(.rel.plt)                } > > -  .rela.plt      : { *(.rela.plt)               } > > +  .rel.plt      : > > +  { > > +    *(.rel.plt) > > +    PROVIDE_HIDDEN (__rel_iplt_start = .); > > +    *(.rel.iplt) > > +    PROVIDE_HIDDEN (__rel_iplt_end = .); > > +  } > > +  .rela.plt       : > > +  { > > +    *(.rela.plt) > > +    PROVIDE_HIDDEN (__rela_iplt_start = .); > > +    *(.rela.iplt) > > +    PROVIDE_HIDDEN (__rela_iplt_end = .); > > +  } > > PROVIDE_HIDDEN etc. were removed by > 8733f6093c2b77502e7228503fc22024e51599b8 in order to support BSDs with > older binutils (2.15). Maybe the ld scripts should be generated from a > source file for example with CPP, so these lines could be tweaked. > It seems this patch was in my local tree for too long, and it seems I should have updated it before sending it... Other architectures are now using PROVIDE instead of PROVIDE_HIDDEN for __rel{a,}_iplt_{start,end}, so I guess the same can be done for sparc and ppc. I am going to do a test build to check that, and I'll come with a new patch if it works. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net