From: Aurelien Jarno <aurelien@aurel32.net>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 26/30] grackle: remove broken pci device
Date: Sun, 8 Jan 2012 02:46:06 +0100 [thread overview]
Message-ID: <20120108014606.GF20942@hall.aurel32.net> (raw)
In-Reply-To: <1325551939-24749-27-git-send-email-aliguori@us.ibm.com>
On Mon, Jan 02, 2012 at 06:52:15PM -0600, Anthony Liguori wrote:
> I have no idea what's going on here, but this is broken and cannot possibly
> work because:
>
> 1) It's qdev name conflicts with a device that sits on SysBus
>
> 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice
>
> If you do qdev_create("grackle"), the code expects to get the SysBus version
> so drop the mystery PCI version.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> hw/grackle_pci.c | 17 -----------------
> 1 files changed, 0 insertions(+), 17 deletions(-)
NACK. Maybe the current code is not correct, but it actually works, and
a PCI host device like this one is definitely needed on the system.
Trying to apply this patch, qemu-system-ppc fails to start with:
qemu: hardware error: Unknown device 'grackle' for bus 'PCI'
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-01-08 1:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 0:51 [Qemu-devel] qom: add QEMU Object Model type hierarchy to qdev (v2) Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 01/30] macio: convert to qdev Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 02/30] openpic: remove dead code to make a PCI device version Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support Anthony Liguori
2012-01-05 15:16 ` François Revol
2012-01-13 10:59 ` Benjamin Herrenschmidt
2012-01-13 11:04 ` Andreas Färber
2012-01-13 11:45 ` Paolo Bonzini
2012-01-13 12:30 ` Alexander Graf
2012-01-13 14:24 ` Andreas Färber
2012-01-13 14:29 ` Alexander Graf
2012-01-03 0:51 ` [Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev Anthony Liguori
2012-01-03 14:57 ` Andreas Färber
2012-01-07 0:11 ` Andreas Färber
2012-01-03 0:51 ` [Qemu-devel] [PATCH 05/30] pseries: Remove hcalls callback Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 06/30] pci: call reset unconditionally Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 07/30] qom: add the base Object class (v2) Anthony Liguori
2012-01-03 9:02 ` Paolo Bonzini
2012-01-03 0:51 ` [Qemu-devel] [PATCH 08/30] qdev: integrate with QEMU Object Model (v2) Anthony Liguori
2012-01-03 0:51 ` [Qemu-devel] [PATCH 09/30] qdev: move qdev->info to class Anthony Liguori
2012-01-08 2:27 ` Andreas Färber
2012-01-03 0:51 ` [Qemu-devel] [PATCH 10/30] qdev: don't access name through info Anthony Liguori
2012-01-03 9:06 ` Paolo Bonzini
2012-01-03 13:39 ` Anthony Liguori
2012-01-03 13:41 ` Paolo Bonzini
2012-01-03 0:52 ` [Qemu-devel] [PATCH 11/30] qdev: use a wrapper to access reset and promote reset to a class method Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 12/30] qdev: add a interface to register subclasses Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 13/30] qdev: add class_init to DeviceInfo Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion Anthony Liguori
2012-01-04 14:07 ` Andreas Färber
2012-01-04 14:24 ` Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 15/30] isa: convert to QEMU Object Model Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 16/30] usb: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 17/30] ccid: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 18/30] ssi: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 19/30] i2c: rename i2c_slave -> I2CSlave Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 20/30] i2c: smbus: convert to QEMU Object Model Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 21/30] hda-codec: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 22/30] ide: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 23/30] scsi: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 24/30] spapr: convert to QEMU Object Model (v2) Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 25/30] virtio-serial: convert to QEMU Object Model Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 26/30] grackle: remove broken pci device Anthony Liguori
2012-01-08 1:46 ` Aurelien Jarno [this message]
2012-01-08 1:55 ` Andreas Färber
2012-01-03 0:52 ` [Qemu-devel] [PATCH 27/30] unin_pci: remove phantom qdev devices in unin_pci Anthony Liguori
2012-01-08 2:04 ` Andreas Färber
2012-01-03 0:52 ` [Qemu-devel] [PATCH 28/30] pci: convert to QEMU Object Model Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 29/30] sysbus: " Anthony Liguori
2012-01-03 0:52 ` [Qemu-devel] [PATCH 30/30] virtio-s390: " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120108014606.GF20942@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).