From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjhps-00043A-TN for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rjhpr-00088c-NC for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:46:12 -0500 Received: from hall.aurel32.net ([88.191.126.93]:45315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjhpr-00088W-IL for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:46:11 -0500 Date: Sun, 8 Jan 2012 02:46:06 +0100 From: Aurelien Jarno Message-ID: <20120108014606.GF20942@hall.aurel32.net> References: <1325551939-24749-1-git-send-email-aliguori@us.ibm.com> <1325551939-24749-27-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1325551939-24749-27-git-send-email-aliguori@us.ibm.com> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 26/30] grackle: remove broken pci device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org, Andreas =?iso-8859-15?Q?F=E4rber?= , Markus Armbruster On Mon, Jan 02, 2012 at 06:52:15PM -0600, Anthony Liguori wrote: > I have no idea what's going on here, but this is broken and cannot possibly > work because: > > 1) It's qdev name conflicts with a device that sits on SysBus > > 2) The PCI constructor expects a SysBus device... but's it's a PCIDevice > > If you do qdev_create("grackle"), the code expects to get the SysBus version > so drop the mystery PCI version. > > Signed-off-by: Anthony Liguori > --- > hw/grackle_pci.c | 17 ----------------- > 1 files changed, 0 insertions(+), 17 deletions(-) NACK. Maybe the current code is not correct, but it actually works, and a PCI host device like this one is definitely needed on the system. Trying to apply this patch, qemu-system-ppc fails to start with: qemu: hardware error: Unknown device 'grackle' for bus 'PCI' -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net