From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjw42-0003XK-EP for qemu-devel@nongnu.org; Sun, 08 Jan 2012 11:57:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rjw41-0006yY-6Y for qemu-devel@nongnu.org; Sun, 08 Jan 2012 11:57:46 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:40558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjw40-0006yU-To for qemu-devel@nongnu.org; Sun, 08 Jan 2012 11:57:45 -0500 Received: by eekb45 with SMTP id b45so2094274eek.4 for ; Sun, 08 Jan 2012 08:57:44 -0800 (PST) From: Marek Vasut Date: Sun, 8 Jan 2012 17:57:41 +0100 References: <1325967077-10130-1-git-send-email-marek.vasut@gmail.com> <201201081702.59630.marek.vasut@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201201081757.42171.marek.vasut@gmail.com> Subject: Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org > On 8 January 2012 16:02, Marek Vasut wrote: > >> Can you point me to some documentation? I looked at > >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch= > >> 1&s r=7 (i.MX28 Applications Processor Reference Manual) and although it > >> has a number of UARTs none of them looked obviously like PL011s. > > > > That's it, look at DUART section and Memory map section. > > That doesn't document that it implements the ID registers at all :-) Well ... can't be helped. > Does the hardware give the ID registers the same values as stock > PL011 or are the part number/designer/etc fields different? Slightly different, but compatible with Linux: 80075fe0: 00000011 00000010 00000024 00000000 ........$....... 80075ff0: 0000000d 000000f0 00000005 000000b1 ................ > > Anyway, the right approach to this is going to be to have either > (a) a qdev device with a different name [this is how we handle > the pl061 variant in the Stellaris Luminary, for instance] > (b) qdev properties > so you can get the mx28 right. This seems more correct/extensible approach. M > > -- PMM