From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rkbf4-000693-FC
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 08:22:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rkbey-0001lc-Pi
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 08:22:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rkbey-0001lP-J8
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 08:22:40 -0500
Date: Tue, 10 Jan 2012 11:21:54 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120110112154.500fa83b@doriath>
In-Reply-To: <20120110083907.GB13145@stefanha-thinkpad.localdomain>
References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com>
	<4F0B1016.2010600@us.ibm.com>
	<20120110083907.GB13145@stefanha-thinkpad.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Please read: make check framework
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Mark McLoughlin <markmc@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, "Edgar E.
	Iglesias" <edgar.iglesias@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, Andreas =?ISO-8859-1?B?RuRyYmVy?= <andreas.faerber@web.de>, =?ISO-8859-1?B?SGVy?= =?ISO-8859-1?B?duk=?= Poussineau <hpoussin@reactos.org>, Avi Kivity <avi@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Stefan Weil <sw@weilnetz.de>, Riku Voipio <riku.voipio@iki.fi>, Jan Kiszka <jan.kiszka@web.de>, Paul Brook <paul@codesourcery.com>, Paolo Bonzini <pbonzini@redhat.com>, Daniel Gollub <gollub@b1-systems.de>, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>, Richard Henderson <rth@twiddle.net>, Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Michael Walle <michael@walle.cc>, Amit Shah <amit.shah@redhat.com>, "Vassili Karpov (malc)" <av1474@comtv.ru>, Aurelien Jarno <aurelien@aurel32.net>

On Tue, 10 Jan 2012 08:39:07 +0000
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Mon, Jan 09, 2012 at 10:04:38AM -0600, Anthony Liguori wrote:
> > The general rules for 'make check-quick':
> > 
> >  1) It must complete in less than 10 minutes start to finish (the
> > entire rule).  We can re-examine this over time but for now, it
> > seems like a reasonable limit.
> > 
> >  2) It must gracefully degrade across architectures/targets.  Do not
> > assume qemu-system-x86_64 is present or that an arm cross compiler
> > is available.
> 
> This should be captured in qemu/ documentation somewhere, otherwise it
> will be quickly forgotten or newcomers will not be aware.

Submitting patches also should have a clause asking submitters to run
the suite before posting patches.

> 
> Stefan
>