From: Marcelo Tosatti <mtosatti@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Shan, Haitao" <haitao.shan@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"avi@redhat.com" <avi@redhat.com>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>
Subject: Re: [Qemu-devel] [PATCH 1/3]use int64 when compare two time
Date: Tue, 10 Jan 2012 14:51:07 -0200 [thread overview]
Message-ID: <20120110165107.GA2730@amt.cnet> (raw)
In-Reply-To: <CAFEAcA8BgTkYh3h_hn_RgkKswMmFsWiL+FnoH=hNkHJcHb6wkw@mail.gmail.com>
On Fri, Jan 06, 2012 at 01:20:55PM +0000, Peter Maydell wrote:
> On 6 January 2012 07:37, Zhang, Yang Z <yang.z.zhang@intel.com> wrote:
> > use int64 when compare two time
> >
> > int32 only represent only 136 years when comparing two times based on second. It would be better to use int64.
>
> "int32", "int32_t" and "'int' which happens to be 32 bit" are all
> different types;
> your changelog message is confusing them.
>
> Anyway, maybe we should be using time_t here? The functions use that
> internally anyway so is there a reason not to just use it in the API too?
time_t contains seconds since Epoch, which is not the case with
offsets in qemu_get_timedate/qemu_timedate_diff.
next prev parent reply other threads:[~2012-01-10 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 7:37 [Qemu-devel] [PATCH 1/3]use int64 when compare two time Zhang, Yang Z
2012-01-06 13:20 ` Peter Maydell
2012-01-10 16:51 ` Marcelo Tosatti [this message]
2012-01-06 17:44 ` Andreas Färber
2012-01-10 5:18 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110165107.GA2730@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=haitao.shan@intel.com \
--cc=kvm@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).